feat: implement environment list command (#260) #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'list' command to display all environments in the workspace. Application Layer: - Add ListCommandHandler with directory scanning logic - Add EnvironmentList and EnvironmentSummary DTOs - Add ListCommandHandlerError with comprehensive help messages Domain Layer: - Add state_display_name() to AnyEnvironmentState - Add provider_display_name() to ProviderConfig and AnyEnvironmentState - Remove duplicated format_provider_name() from show handler Presentation Layer: - Add ListCommandController orchestrating the workflow - Add EnvironmentListView for table rendering - Add ListSubcommandError with help() methods - Register 'list' command in CLI parser and router - Integrate into Container for dependency injection Features: - Scans data/ directory for environment.json files - Displays table with name, state, provider, created_at - Handles empty workspaces with helpful guidance - Reports partial failures without stopping - No network calls (read-only local operation)
ProgressReporter.complete_step() and sub_step() were incorrectly using output.result() (stdout) instead of output.progress() (stderr). This caused progress indicators like '✓ Found 2 environment(s)' to appear on stdout, making it impossible to pipe clean command output. Now running 'cargo run -- list 2>/dev/null' shows only the actual result data, with all progress messages properly going to stderr.
Member
Author
|
ACK 77fba2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
listcommand to display all environments in the workspace, as specified in issue #260.Changes
Application Layer
ListCommandHandlerwith directory scanning logicEnvironmentListandEnvironmentSummaryDTOs for data transferListCommandHandlerErrorwith comprehensive help messagesDomain Layer
state_display_name()method toAnyEnvironmentStatefor human-readable state namesprovider_display_name()method toProviderConfigandAnyEnvironmentStateformat_provider_name()function from show handler (moved to domain layer)Presentation Layer
ListCommandControllerorchestrating the two-step workflowEnvironmentListViewfor table renderingListSubcommandErrorwith detailed.help()methodslistcommand in CLI parser and routerContainerfor dependency injectionFeatures
data/directory forenvironment.jsonfilesExample Output
Testing
Related Issue
Closes #260