Skip to content

[TOW-1213] Remove the package information from the logs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammuti wants to merge 1 commit into from
Closed

[TOW-1213] Remove the package information from the logs #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/tower-uv/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ impl Uv {
.arg("--color")
.arg("never")
.arg("--no-progress")
.arg("--quiet")
Copy link
Contributor Author

@sammuti sammuti Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to have some sort of VERBOSE or DEBUG flag to enable these since this may hide legit relevant problems sometimes...
@bradhe any thoughts?

Copy link
Contributor

@bradhe bradhe Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? I think this is quite useful information actually--helps with debugging and knowing what packages were installed.

Copy link
Contributor Author

@sammuti sammuti Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm may be I misunderstood this line from the task

We should remove the package information from the logs, it's not useful to our users.

at https://linear.app/towerhq/issue/TOW-1213/improve-logging-in-tower-runner

.arg("sync")
.envs(env_vars);

Expand Down Expand Up @@ -191,6 +192,7 @@ impl Uv {
.current_dir(cwd)
.arg("--color")
.arg("never")
.arg("--quiet")
.arg("pip")
.arg("install")
.arg("-r")
Expand Down
Loading