Skip to content

Conversation

@socksy
Copy link
Contributor

@socksy socksy commented Dec 11, 2025

Using the same pattern for checking if in MCP mode as we do for remote runs, but on thinking about it I am not 100% sure it's necessary to differentiate any more — I would investigate and change it for both though, here I'm just trying to get the same behaviour as with remote runs.

Used AI to help me research the rust thing of "how do I get access to the ability to cancel the app".

First rabbithole was cloning the application cancellation token, and debugging lifecycle stuff. However, I found it simpler to follow by wrapping the app in an Arc<Mutex<>>, and have both the stream process and the main control loop have references to the same app, and call .terminate() on it directly.

@github-actions
Copy link

⚠️ WARNING: This PR targets main instead of develop

This PR is targeting main which will trigger a production deployment when merged.

If this is a regular feature/fix PR, please change the base branch to develop.
If this is intentional (e.g., hotfix), you can ignore this warning.

Current base: main
Recommended base: develop

@socksy socksy changed the base branch from main to develop December 11, 2025 16:03
Copy link
Contributor

@bradhe bradhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU. This was really annoying me.

@socksy socksy merged commit a6ec0e1 into develop Dec 12, 2025
7 of 8 checks passed
@socksy socksy deleted the feature/tow-1250-when-running-tower-run-local-on-notebooks-and-ctrl-c-the branch December 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants