Skip to content

Conversation

@cbrinicombe13
Copy link
Member

I changed the new PUT API to be the 'explicit identification API' and moved the old one to just a 'create user API'. Think that makes more sense.

I also think we should change the SDK method name from .upsert() to .identify() to match the use case better. But i'll need you to change the SDK generation code for that.

@jasontlouro
Copy link
Contributor

jasontlouro commented Jul 22, 2025

This repo should never alter openapi.yml since it will just get overwritten the next time app gets a push to master. The GH Action on it copies its openapi.yml to here. So those changes should be in an app PR

While you're there, to change users.upsert to users.identify I believe it is just changing users_upsert to users_identify here

but obviously that will break RD's code the next time they upgrade the package version

@cbrinicombe13
Copy link
Member Author

I'll create a PR in the app repo as well then can merge both at the same time

@cbrinicombe13
Copy link
Member Author

@cbrinicombe13 cbrinicombe13 merged commit 285ec37 into main Jul 23, 2025
2 checks passed
@cbrinicombe13 cbrinicombe13 deleted the new-identify-api branch July 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants