Skip to content

Conversation

@jmorris-uk
Copy link
Contributor

@jmorris-uk jmorris-uk commented Jan 21, 2025

Description

Adds correct outputting of the cryoplant efficiency from issue #1431

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.26%. Comparing base (d3135bd) to head (32465d1).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
process/power.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   30.27%   30.26%   -0.01%     
==========================================
  Files          80       80              
  Lines       19501    19506       +5     
==========================================
  Hits         5903     5903              
- Misses      13598    13603       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine, just a comment to clarify please.

)

# Cryo-plants efficiencies
if abs(tfcoil_variables.eff_tf_cryo + 1) < 1e-6:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on the significance of this if?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eff_tf_cryo needs to be an input but keeping the existing default values

4 participants