-
Notifications
You must be signed in to change notification settings - Fork 17
More accurately simulate the neutron flux profile #3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
OceanNuclear
wants to merge
98
commits into
main
Choose a base branch
from
neutronics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3653 +/- ##
==========================================
- Coverage 45.98% 42.77% -3.22%
==========================================
Files 123 125 +2
Lines 28550 38543 +9993
==========================================
+ Hits 13129 16486 +3357
- Misses 15421 22057 +6636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a7c3d81 to
56884d7
Compare
…ng the strength of the macroscopic (self and other) scattering matrix.
…(...)), instead of using complex number to cover both +ve and -ve sign in the sqrt.
…esmos). Next step is to write the program for solving multi-group fluxes.
77503de to
93c5e9c
Compare
…ed classes and functions are now in neutronics_data.
…have to import openmc.
…for ease of maintenace; added tests.
6585fda to
5ada3ea
Compare
…nded_boundary, to be self-populating dictionaries (populated by solve_group_n).
…d populated the docstring of NeutronFluxProfile.
…of commits ago (because I was in a hurry) in groupwise_neutron_current_through_interface
…nup successful: unit test and regression test (1-group regression test case only) passed. Only the plotting function remains to be fixed for this conversion to infinite-layer model.
…haviour of (NeutronFluxProfile.coefficients, NeutronFluxProfile.l2, NeutronFluxProfile.diffusion_const)
…aries (i.e. interfaces) are properly drawn. Will need to make heating calculation method.
…r both flux and current, but not for heating yet.
…its from eV to Joule
…so they're still valid under the new units (J, instead of eV)
…iscontinuity present are all justified (i.e. have physical meaning). This in turn updated the behaviour of some methods, and notably two new methods are added to calculate the heating in a per-layer fashion. Docstring updates as well.
… exist without first re-writing solve_lowest_group
…p while keeping _calculate_mean_energy_and_incident_bin as a staticmethod.
Contributor
Author
…each NeutronFluxProfile.coefficient[:, n] will contain self.n_groups coefficients rather than n coefficients.
…'s coefficients (i.e. coefficients used to cancel the flux shapes contributed by other groups).
… coefficient length = total number of groups rather than the current group number.
…the programmer won't have to write them out explicitly every time.
…us layer can be written as an affine transformation in linear algebra (y = Ax+b). The method _get_propagation_matrix_and_offset_vec returns A and b. num_coef_pairs is no longer needed so is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
Calculates the neutron flux profile in the first wall and blanket, using an extremely simplified diffusion-based model of an infinite slab sandwich.
Reason for choosing this model
It's better than not having a neutronics model.
It's also very simplified, so it can be calculated on the fly, without installing any deterministic neutron transport codes as dependency.
Checklist
I confirm that I have completed the following checks: