Skip to content

Conversation

@je-cook
Copy link
Collaborator

@je-cook je-cook commented Nov 14, 2025

Description

Closes #3669

This changes the install to use a pyproject.toml. Some things to consider when reviewing:

  • This now uses hatch(ling) to replace setuptools with hatch-vcs to create the version dynamically based off the git tag
  • Ive moved all the requirements into the pyproject and slightly rearranded them, probably could be done better
  • All the ruff config is now in the file
  • All the data is included via the artefacts bit
  • The pyproject was copied and modified from one of my other packages so may need some small cleanup

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.03%. Comparing base (a188483) to head (6b48d4c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
+ Coverage   45.99%   46.03%   +0.04%     
==========================================
  Files         123      123              
  Lines       29002    28964      -38     
==========================================
- Hits        13340    13335       -5     
+ Misses      15662    15629      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould self-requested a review November 17, 2025 16:58
@hsaunders1904
Copy link

Adding some support for the pyproject way of doing things: the current version number in setup.py does not match the version number for the latest release (3.2.2):

"version": "3.2.1",

This change would mean not having to remember to update the number in the future.

@clmould clmould force-pushed the pyproject branch 3 times, most recently from 3921f01 to d0e578d Compare December 18, 2025 11:17
Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions about which dependencies should be installed in the testing jobs. I think part of our tests job is to check we have our dependencies sorted out hence we should be strict with which dependencies are installed in these jobs--other jobs dont matter so much.

Copy link
Collaborator

@timothy-nunn timothy-nunn Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new issues should be created from this:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I recommend https://github.com/Fusion-Power-Plant-Framework/fppf-actions or modifications to it to unite our CI

Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy editable install

5 participants