Skip to content

Conversation

@clmould
Copy link
Collaborator

@clmould clmould commented Dec 12, 2025

Description

Closes #4008

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould requested a review from je-cook December 12, 2025 17:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.99%. Comparing base (a188483) to head (628a0b8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4009   +/-   ##
=======================================
  Coverage   45.99%   45.99%           
=======================================
  Files         123      123           
  Lines       29002    29002           
=======================================
  Hits        13340    13340           
  Misses      15662    15662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the clean-up-examples-nb branch from 7a63157 to 5f3d713 Compare December 18, 2025 15:59
@clmould clmould requested a review from timothy-nunn December 18, 2025 16:34
"temp_dir, temp_input_path, _ = copy_to_temp_dir(input_rel)\n",
"\n",
"# Run process on an input file\n",
"single_run = SingleRun(temp_input_path.as_posix())\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed (back)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had rebase trouble with this (not entirely sure why, it kept glitching out). Simplest solution was for me to redo the initial rebase and have made a new pr where everything is correct now #4022

@clmould
Copy link
Collaborator Author

clmould commented Dec 18, 2025

Had rebase trouble so re-opened in #4022

@clmould clmould closed this Dec 18, 2025
@timothy-nunn timothy-nunn deleted the clean-up-examples-nb branch December 24, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine csv example into examples.ipynb

5 participants