Skip to content

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Dec 17, 2025

This pull request introduces a comprehensive renaming and standardization of variable names related to the TF coil cooling system throughout the codebase and documentation. The changes improve clarity and consistency, making it easier to understand and maintain the code. Additionally, some minor updates were made to plots and documentation to reflect these changes and provide more detailed information.

Variable Renaming and Standardization

  • Renamed TF coil cooling variables for clarity and consistency:

    • tcoolintemp_cp_coolant_inlet
    • rcoolradius_cp_coolant_channel
    • vcoolvel_cp_coolant_midplane
    • ncooln_cp_coolant_channels_total
    • dtiocooldtemp_cp_coolant
  • Updated all input files and process logic to use new variable names, ensuring backward compatibility via the obsolete variable mapping.

Documentation Improvements

  • Added a section to the standards documentation specifying the naming convention for temperature changes, introducing the dtemp_ prefix for relative temperature rises or falls.

Plot and Visualization Enhancements

  • Added a detailed cooling information box to the TF coil winding pack plot, showing coolant inlet temperature, temperature rise, velocity, and other relevant data.
  • Made minor adjustments to plot text and annotation positions for improved readability.

Minor Additions

  • Added initialization for a new variable m_tf_wp_steel_conduit in tfcoil_variables.py.## Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added Bug Something isn't working TF Coil Toroidal field coil Variable rename labels Dec 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.05%. Comparing base (2f754a2) to head (db27934).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 0.00% 4 Missing ⚠️
process/init.py 0.00% 2 Missing ⚠️
process/resistive_tf_coil.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4014      +/-   ##
==========================================
- Coverage   45.88%   44.05%   -1.84%     
==========================================
  Files         123      123              
  Lines       29087    30948    +1861     
==========================================
+ Hits        13346    13633     +287     
- Misses      15741    17315    +1574     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe self-assigned this Dec 18, 2025
@chris-ashe chris-ashe marked this pull request as ready for review December 18, 2025 15:50
@chris-ashe chris-ashe force-pushed the quick_resistive_tf_fixes branch from 1f7e585 to db27934 Compare December 18, 2025 15:50
Copy link
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working TF Coil Toroidal field coil Variable rename

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants