Issue 63 iid apd10 1 #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good. Please resolve the linting issues for the CI/CD to pass.
|
- Only IID assumption on the data (i.e. the +ve and -ve samples for a particular embedding appear i.i.d from the true distribution - uses wilson_confidence_interval for binomial distribution to get better approximations for extreme similarity value (i.e. near 1)
Earlier IID bounded the error by (\epsilon + \delta). Modified it to now bound it by (\delta) as required.
apd10
force-pushed
the
issue-63-iid-apd10-1
branch
from
302c0fd to
94d0be4
Compare
luis-gasparschroeder
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.