Adding number of users for each language in get languages endpoint #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogoncalves
changed the title
|
Inconsistent use of single vs double quotes, but otherwise looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vdaubry
I decided to make it an option because up until now the return was an array of strings instead of objects.
Since I have the app in production it would break things (V1 should have the return type always as a Language object (name: "", users:""... whatever). This way it wouldn't break things when adding fields like this example.
So in this case if we send the boolean, we get an array of objects, if not we still get an array of strings..
Not perfect, but what I came up with.
Let me know what you think.