Skip to content

Dedup segmented webvtt captions with the same id (fixes #1688) #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gjdipietro wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dedup segmented webvtt captions with the same id (fixes #1688) #1691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5009b6
fix(player): dedup segmented webvtt captions with the same id (#1688)
gjdipietro Sep 4, 2025
c9ecffa
remove id from cueIds on removeCue
gjdipietro Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/vidstack/src/core/tracks/text/text-track.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export class TextTrack extends EventsTarget<TextTrackEvents> {
#regions: VTTRegion[] = [];
#cues: VTTCue[] = [];
#activeCues: VTTCue[] = [];
#cueIds = new Set<string>();

/** @internal */
[TextTrackSymbol.readyState]: TextTrackReadyState = 0;
Expand Down Expand Up @@ -128,6 +129,12 @@ export class TextTrack extends EventsTarget<TextTrackEvents> {
}

addCue(cue: VTTCue, trigger?: Event): void {
// deduplicate cues with the same id
if (cue.id) {
if (this.#cueIds.has(cue.id)) return;
this.#cueIds.add(cue.id);
}

let i = 0,
length = this.#cues.length;

Expand All @@ -152,6 +159,7 @@ export class TextTrack extends EventsTarget<TextTrackEvents> {
const index = this.#cues.indexOf(cue);
if (index >= 0) {
const isActive = this.#activeCues.includes(cue);
if (cue.id) this.#cueIds.delete(cue.id);
this.#cues.splice(index, 1);
this[TextTrackSymbol.native]?.track.removeCue(cue);
this.dispatchEvent(new DOMEvent<VTTCue>('remove-cue', { detail: cue, trigger }));
Expand Down