Record output_tokens for incomplete requests #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets
continuous_usage_statsto get token usage on incomplete requests. If usage is still unavailable fall back to iteration count.Details
In v0.3.0 and earlier the number of iterations was used as proxy for output token count in incomplete requests that did not return usage metrics. In v0.4.0 this behavior was removed which lead to large discrepancies in output token count based on the percentage of the benchmark consisting of incomplete requests.
This PR restore the original behavior of falling back to number of iterations. Additionally it sets the
continuous_usage_statsflag to enable usage metrics on every iteration, when available.Test Plan
max-secondsconstraint. For incomplete requests check that output_tokens is greater than 0 for some requests.Related Issues
Use of AI
## WRITTEN BY AI ##)