Skip to content

Conversation

@dogknowsnx
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64-glibc

cc @tranzystorekk

Package is unusable w/o a font present on a base install
@tranzystorekk
Copy link
Contributor

I'm not sure fonts are a good thing to add as dependency, while I acknowledge labwc won't start without any font installed, it should be a user choice and responsibility to install/provide such things.

@dogknowsnx
Copy link
Contributor Author

dogknowsnx commented Dec 27, 2025

I'm not sure fonts are a good thing to add as dependency, while I acknowledge labwc won't start without any font installed, it should be a user choice and responsibility to install/provide such things.

I beg to differ. The user could ignore and uninstall the font, but at least labwc would be usable and "complete" runtime dep-wise (I deliberately picked a decent yet relatively small font package) - anyway, you're the maintainer, so please close if you really consider this change unnecessary.

@classabbyamp
Copy link
Member

I was playing around with virtual providers for this kind of thing: master...classabbyamp:void-packages:font-providers

@dogknowsnx dogknowsnx marked this pull request as draft December 27, 2025 20:56
@dogknowsnx
Copy link
Contributor Author

Another affected package that comes to mind would be niri afaik (not using it myself, though)

@wbohrer
Copy link
Contributor

wbohrer commented Dec 28, 2025

Another affected package that comes to mind would be niri afaik (not using it myself, though)

Any non-DE Wayland or xorg-minimal setup will not install any fonts by default. Users that can setup custom graphical environments should be advanced enough to know to install fonts. The virtual provider solution is the smartest safeguard IMO.

@ahesford
Copy link
Member

ahesford commented Dec 28, 2025

We don't pull in arbitrary packages because they implement one of the myriad options that a package may need to run. We currently lack the tools to properly balance the convenience of one class of users against those of another, so we default to the expectation that users should be sufficiently capable to discover which optional packages they need to provide the desired functionality.

If the virtual font experiment draws to a successful close, we can consider using that here.

@ahesford ahesford closed this Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants