Skip to content

[WIP] VS Code style invalid validation for textfield #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
a-stewart wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] VS Code style invalid validation for textfield #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/vscode-textfield/vscode-textfield.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,19 @@ const styles: CSSResultGroup = [
border-width: 1px;
box-sizing: border-box;
color: var(--vscode-settings-textInputForeground, #cccccc);
display: flex;
display: block;
max-width: 100%;
position: relative;
width: 100%;
}

.container {
display: flex;
width: stretch;
width: -webkit-fill-available;
width: -moz-available;
}

:host([focused]) .root {
border-color: var(--vscode-focusBorder, #0078d4);
}
Expand All @@ -41,9 +48,25 @@ const styles: CSSResultGroup = [

:host([invalid]) input,
:host(:invalid) input {
/* background-color: var(--vscode-inputValidation-errorBackground, #5a1d1d); */
}

#error-message {
display: none;
width: stretch;
width: -webkit-fill-available;
width: -moz-available;
padding: 5px;
color: var(--vscode-inputValidation-errorForeground, var(--vscode-settings-textInputForeground, #cccccc));
border-top: 1px solid var(--vscode-inputValidation-errorBorder, #be1100);
background-color: var(--vscode-inputValidation-errorBackground, #5a1d1d);
}

:host([invalid]) #error-message,
:host(:invalid) #error-message {
display: block;
}

::slotted([slot='content-before']) {
display: block;
margin-left: 2px;
Expand Down
61 changes: 34 additions & 27 deletions src/vscode-textfield/vscode-textfield.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,9 @@ export class VscodeTextfield
@query('#input')
private _inputEl!: HTMLInputElement;

@query('#error-message')
private _errorMessageEl!: HTMLDivElement;

@state()
private _value = '';

Expand Down Expand Up @@ -322,6 +325,7 @@ export class VscodeTextfield
this._inputEl
);
}
this._errorMessageEl.innerText = this._inputEl.validationMessage;
}

private _onInput() {
Expand Down Expand Up @@ -353,34 +357,37 @@ export class VscodeTextfield
override render(): TemplateResult {
return html`
<div class="root">
<slot name="content-before"></slot>
<input
id="input"
type=${this.type}
?autofocus=${this.autofocus}
autocomplete=${ifDefined(this.autocomplete)}
aria-label=${this.label}
?disabled=${this.disabled}
max=${ifDefined(this.max)}
maxlength=${ifDefined(this.maxLength)}
min=${ifDefined(this.min)}
minlength=${ifDefined(this.minLength)}
?multiple=${this.multiple}
name=${ifDefined(this.name)}
pattern=${ifDefined(this.pattern)}
placeholder=${ifDefined(this.placeholder)}
?readonly=${this.readonly}
?required=${this.required}
step=${ifDefined(this.step)}
.value=${this._value}
@blur=${this._onBlur}
@change=${this._onChange}
@focus=${this._onFocus}
@input=${this._onInput}
@keydown=${this._onKeyDown}
>
<slot name="content-after"></slot>
<div class="container">
<slot name="content-before"></slot>
<input
id="input"
type=${this.type}
?autofocus=${this.autofocus}
autocomplete=${ifDefined(this.autocomplete)}
aria-label=${this.label}
?disabled=${this.disabled}
max=${ifDefined(this.max)}
maxlength=${ifDefined(this.maxLength)}
min=${ifDefined(this.min)}
minlength=${ifDefined(this.minLength)}
?multiple=${this.multiple}
name=${ifDefined(this.name)}
pattern=${ifDefined(this.pattern)}
placeholder=${ifDefined(this.placeholder)}
?readonly=${this.readonly}
?required=${this.required}
step=${ifDefined(this.step)}
.value=${this._value}
@blur=${this._onBlur}
@change=${this._onChange}
@focus=${this._onFocus}
@input=${this._onInput}
@keydown=${this._onKeyDown}
>
<slot name="content-after"></slot>
</div>
</div>
<div id="error-message">${this.validationMessage}</div>
`;
}
}
Expand Down
Loading