Skip to content

Fix unselectable filtered option when clicking #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bendera wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix unselectable filtered option when clicking #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/includes/vscode-select/vscode-select-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ export class VscodeSelectBase extends VscElement {

if (changedProperties.has('open') && this._firstUpdateCompleted) {
if (this.open) {
this._dropdownEl.showPopover();
if (this.isConnected) {
this._dropdownEl.showPopover();
}

const {x, y} = this.getBoundingClientRect();
this._prevXPos = x;
Expand Down Expand Up @@ -566,8 +568,13 @@ export class VscodeSelectBase extends VscElement {
this.focused = true;
};

private _onComponentBlur = () => {
protected _onComponentBlur = () => {
this._toggleComboboxDropdown();
this.focused = false;

if (this._opts.multiSelect) {
this._opts.filterPattern = '';
}
};

protected _onSlotChange(): void {
Expand Down
1 change: 0 additions & 1 deletion src/vscode-multi-select/vscode-multi-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,6 @@ export class VscodeMultiSelect

protected override _onComboboxInputBlur(): void {
super._onComboboxInputBlur();
this._opts.filterPattern = '';
}
//#endregion

Expand Down
Loading