-
Notifications
You must be signed in to change notification settings - Fork 260
support OpenHarmony #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
support OpenHarmony #1642
Conversation
|
Congrats on the port. This is the first time I've come across OpenHarmony, so I guess I've my head down in the Vulkan bunker a bit too long :-) What hardware have you tested on? How straight forward would it be to create a dual boot with OpenHarmony on a desktop to sit along a desktop Linux variants like Ubunut/Kubuntu? |
|
Sorry, perhaps I misspoke about OpenHarmony. I only tested it on a Huawei HarmonyOS phone. Currently, setting up the OpenHarmony environment is a bit complicated. However, the NDK interface for HarmonyOS is consistent with that of OpenHarmony. |
This reverts commit 5b4aebd.
|
I have merged your changes as a HarmonySupport branch: https://github.com/vsg-dev/VulkanSceneGraph/tree/HarmonySupport I have done a first pass and I have come away wondering whether using OHOS prefix is a bit too specific OpenHarmonyOS as you've been testing with HarmonyOS so that's clearly supported to. Would just using Harmony as a prefix be OK? |
|
@Dylan-H I'm inclined to rename include/vsg/platform/ohos to include/vsg/platform/harmony and vsgOHOS to vsgHarmony and OHOS_Window to Harmony_Window. Thoughts? |
|
To test out a change in naming I have created a new branch based on this PR: https://github.com/vsg-dev/VulkanSceneGraph/tree/HarmonyPlatform The changes are: deb2ee8 @Dylan-H Could provide you test this branch out and provide feedback. |
|
I've added a new merge request to the HarmonyPlatform branch (Fix header file error #1648), fixing a minor issue. I've also submitted a merge request based on this branch in the vsgExamples repository: Add HarmonyOS example #382. |
Description
Add support for OpenHarmony native window
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Similar to the Android platform, a test demo was written to load the teapot model on OpenHarmony for testing.
Test Configuration:
Checklist: