Skip to content

Use ordered list for breadcrumbs to indicate hierarchical order #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polarbirke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ordered list for breadcrumbs to indicate hierarchical order #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Resources/views/Navigation/breadcrumbs-blocks-BEM.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{% block breadcrumbs_label %}
<span class="{{ block('prefix_final') ~ 'breadcrumbs__label' }} {% block breadcrumbs_label_class %}{% endblock %}">{{ "webfactory_navigation.breadcrumb_label"|trans({}, 'webfactory-navigation') }}</span>
{% endblock %}
<ul class="{{ block('prefix_final') ~ 'breadcrumbs__list' }} {% block breadcrumbs_list_class %}{% endblock %}">
<ol class="{{ block('prefix_final') ~ 'breadcrumbs__list' }} {% block breadcrumbs_list_class %}{% endblock %}">
{% for node in breadcrumbs %}
{% if node.caption|trim is not empty and ((node.breadcrumbsVisible is defined and node.breadcrumbsVisible) or node.visible) %}
<li class="{{ block('prefix_final') ~ 'breadcrumbs__item' }} {% block breadcrumbs_item_class %}{% endblock %}">
Expand All @@ -24,7 +24,7 @@
</li>
{% endif %}
{% endfor %}
</ul>
</ol>
</nav>
{% endif %}
{% endblock %}
4 changes: 2 additions & 2 deletions src/Resources/views/Navigation/breadcrumbs.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% if breadcrumbs is defined and breadcrumbs|length > 1 %}
<div class="breadcrumb-wrapper">
<span class="breadcrumb-label">{{ "webfactory_navigation.breadcrumb_label"|trans({}, 'webfactory-navigation') }}</span>
<ul class="breadcrumbs">
<ol class="breadcrumbs">
{% for node in breadcrumbs %}
{% if node.caption|trim is not empty and ((node.breadcrumbsVisible is defined and node.breadcrumbsVisible) or node.visible) %}
<li class="breadcrumb {% if loop.first %}breadcrumb-first{% endif %}">
Expand All @@ -13,6 +13,6 @@
</li>
{% endif %}
{% endfor %}
</ul>
</ol>
</div>
{% endif %}