Remove deprecated options to use snak hashes #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
approved these changes
Sep 1, 2017
Contributor
thiemowmde
left a comment
thiemowmde
left a comment
There was a problem hiding this comment.
This is all fine and cool to have this patch so we don't forget. But as said: This should wait a few weeks. There is no urge to do this breaking release now.
This follows through with the deprecation of the separate options in 4f558c9, leaving only the single unified option behind to control whether snak hashes of any kind are included or not.
thiemowmde
force-pushed
the
removeOptions
branch
from
71febe0 to
c3b03f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows through with the deprecation of the separate options in 4f558c9, leaving only the single unified option behind to control whether snak hashes of any kind are included or not.
This isn’t urgent at all, and constitutes a breaking change (hence 3.0.0 in
RELEASE-NOTES.md). I don’t know when we even want to do a 3.0.0 release, so I’m fine with just leaving this pull request lying around for now :)