Rename Suffix… to PrefixedEntityIdParser #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+2 CR; suggest to wait with merge till concrete plans to do the next breaking release |
Contributor
Author
|
I agree. |
|
Needs rebase. Is this still wanted/needed? |
thiemowmde
force-pushed
the
suffixParser
branch
from
6a9c7ca to
fd93f6f
Compare
Contributor
Author
|
Rebased. I believe this should still be done. The current name sounds like it is a parser that extracts suffixes, but it does the opposite. It parses EntityIDs that are prefixed. |
Contributor
|
Needs rebase again |
thiemowmde
force-pushed
the
suffixParser
branch
from
fd93f6f to
083a438
Compare
JeroenDeDauw
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a parser for entity IDs with suffixes. We (@adrianheine and I) found this confusing today.
This is used in two places in the top level factories of Wikibase.git, nowhere else.