Make differs/patchers required by MediaInfo public #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
Contributor
|
Needs rebase |
thiemowmde
force-pushed
the
publicPatchers
branch
from
79f19a3 to
ee0fd2b
Compare
Contributor
|
Tests went boom |
thiemowmde
force-pushed
the
publicPatchers
branch
from
ee0fd2b to
290fc31
Compare
Contributor
Author
|
A test introduced in #141 broke after rebase. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this conflicts with #141! Please merge #141 first.
For MediaInfo this is a breaking change because this will break the current implementation that uses classes that are in the "Internal" namespace and marked as "packed private" in the class level documentation. However, from the perspective of this component this is not a breaking change and should, in my opinion, go into the planned 3.6 release.