Add MSVC 2026 (Visual Studio 2026) and MinGW workflow support #19
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
wysaid
changed the title
|
@copilot 改一下代码以及git 提交、 workflow、PR 描述等等 里面出现的 vs2025 的字样 |
已修复所有 VS2025 引用，改为 VS2026。同时添加了 MinGW-w64 workflow：
现在 Windows workflow 包含三个 job：
Commit: 81b2777 |
|
@copilot 根据我们的上下文， 我知晓 vs2026 还未被 github 支持。 我认为未来某一天会被支持。 |
已简化 VS2026 job：
输出示例（VS2026 不可用时）： Commit: ba2341d |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive Windows build support for Visual Studio 2026 and MinGW-w64 compilers to complement the existing VS2022 workflow. The VS2026 job includes intelligent detection that gracefully skips when the compiler isn't available on GitHub runners, ensuring forward compatibility when GitHub adds VS2026 support. The MinGW job provides an alternative GCC-based build option using MSYS2.
Key changes:
- Renamed the existing Windows build job to
build-vs2022and updated artifact naming to include the compiler version - Added
build-vs2026job with automatic version detection and graceful skip capability when VS2026 is not available - Added
build-mingwjob using MSYS2 with MinGW-w64 toolchain and Ninja build system - Updated documentation to reflect MSVC 2026 and MinGW-w64 support with CMake 3.31+ recommendation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/windows-build.yml |
Split single Windows build job into three separate jobs (VS2022, VS2026, MinGW), added VS2026 detection logic, configured MinGW with MSYS2, updated artifact naming |
README.md |
Added MSVC 2026 and MinGW-w64 to compiler requirements, noted CMake 3.31+ recommendation for VS2026 |
README.zh-CN.md |
Chinese version of README updates - added MSVC 2026 and MinGW-w64 support documentation |
BUILD_AND_INSTALL.md |
Updated prerequisites to mention VS2026 and MinGW-w64, recommended CMake 3.31+ for MSVC 2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/windows-build.yml
Outdated
| fi | ||
| cd scripts | ||
| if [ "${{ matrix.config }}" == "Debug" ]; then |
There was a problem hiding this comment.
Use = instead of == for string comparison in bash [ ] test construct to maintain consistency with the rest of the file (lines 60, 124, 309, 370) and follow POSIX standards. While == works in bash, it's a bashism and may not work in all shells.
| if [ "${{ matrix.config }}" == "Debug" ]; then | |
| if [ "${{ matrix.config }}" = "Debug" ]; then |
There was a problem hiding this comment.
Fixed bash string comparison from == to = for POSIX compliance.
Commit: 974cb6c
.github/workflows/windows-build.yml
Outdated
| try { | ||
| Write-Host "Attempting to use Visual Studio 18 2026 generator..." | ||
| cmake ../.. -G "Visual Studio 18 2026" -A x64 -DCCAP_BUILD_TESTS=ON $SHARED_FLAG | ||
| } catch { |
There was a problem hiding this comment.
The try-catch block may not work as expected for the cmake command in PowerShell. External commands don't throw exceptions by default. Consider checking $LASTEXITCODE after the first cmake attempt instead of using try-catch, or set $ErrorActionPreference = 'Stop' before the try block to ensure cmake failures are caught.
| try { | |
| Write-Host "Attempting to use Visual Studio 18 2026 generator..." | |
| cmake ../.. -G "Visual Studio 18 2026" -A x64 -DCCAP_BUILD_TESTS=ON $SHARED_FLAG | |
| } catch { | |
| Write-Host "Attempting to use Visual Studio 18 2026 generator..." | |
| cmake ../.. -G "Visual Studio 18 2026" -A x64 -DCCAP_BUILD_TESTS=ON $SHARED_FLAG | |
| if ($LASTEXITCODE -ne 0) { |
There was a problem hiding this comment.
Fixed PowerShell error handling - now using $LASTEXITCODE check instead of try-catch for the cmake command.
Commit: 974cb6c
.github/workflows/windows-build.yml
Outdated
| echo "✓ Windows shared library linking test with MinGW passed" | ||
| - name: Run Unit Tests | ||
| if: matrix.config == 'Release' |
There was a problem hiding this comment.
The MinGW job only runs unit tests for Release builds, while VS2022 and VS2026 jobs run tests for both Debug (functional tests) and Release (performance tests) builds. Consider adding tests for Debug builds to maintain consistency with the other Windows build jobs, or add a comment explaining why MinGW only tests Release builds.
There was a problem hiding this comment.
Added tests for both Debug and Release builds in MinGW job. Now runs functional tests for Debug and performance tests for Release, consistent with VS2022/VS2026 jobs.
Commit: 974cb6c
| mkdir -p build | ||
| if [ ! -L "build/${{ matrix.config }}" ]; then | ||
| ln -sf "${{ matrix.config }}-${{ matrix.library_type }}" "build/${{ matrix.config }}" | ||
| fi |
There was a problem hiding this comment.
The MinGW test setup only creates a symbolic link for build/${{ matrix.config }} but not for build/tests/${{ matrix.config }}, unlike VS2022 and VS2026 jobs (lines 413-423). If the test script expects the tests directory structure, this could cause issues. Verify that ./run_tests.sh --functional --skip-build works correctly with MinGW's simplified symlink setup, or add the tests symlink for consistency.
| fi | |
| fi | |
| mkdir -p build/tests | |
| if [ ! -L "build/tests/${{ matrix.config }}" ]; then | |
| ln -sf "../../${{ matrix.config }}-${{ matrix.library_type }}" "build/tests/${{ matrix.config }}" | |
| fi |
There was a problem hiding this comment.
Added missing tests symlink structure for MinGW builds. Now creates both build/${{ matrix.config }} and build/tests/${{ matrix.config }} symlinks, consistent with other jobs.
Commit: 974cb6c
wysaid
force-pushed
the
copilot/add-msvc-2026-workflow
branch
from
0ee6759 to
01ac04a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| name: Windows Build VS2022 (${{ matrix.config }}-${{ matrix.library_type }}) | ||
| runs-on: windows-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| config: [Debug, Release] | ||
| library_type: [static, shared] | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Visual Studio environment | ||
| uses: microsoft/setup-msbuild@v1.1 | ||
|
|
||
| - name: Configure CMake | ||
| run: | | ||
| $SHARED_FLAG = "" | ||
| if ("${{ matrix.library_type }}" -eq "shared") { | ||
| $SHARED_FLAG = "-DCCAP_BUILD_SHARED=ON" | ||
| Write-Host "Configuring Windows build ${{ matrix.config }} - SHARED LIBRARY (DLL)" | ||
| } else { | ||
| Write-Host "Configuring Windows build ${{ matrix.config }} - STATIC LIBRARY" | ||
| } | ||
| mkdir -p "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| cd "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| cmake ../.. -G "Visual Studio 17 2022" -A x64 -DCCAP_BUILD_TESTS=ON -DBUILD_CCAP_CLI=ON $SHARED_FLAG | ||
| - name: Build | ||
| run: | | ||
| cd "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| cmake --build . --config ${{ matrix.config }} --parallel | ||
| - name: Verify library type | ||
| shell: bash | ||
| working-directory: build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }} | ||
| run: | | ||
| echo "Checking built libraries:" | ||
| ls -la | grep -E "ccap" || echo "No ccap libraries found" | ||
| # Verify library type | ||
| # Debug versions have 'd' suffix, Release versions don't | ||
| if [ "${{ matrix.config }}" = "Debug" ]; then | ||
| LIB_BASENAME="ccapd" | ||
| DLL_NAME="ccapd.dll" | ||
| else | ||
| LIB_BASENAME="ccap" | ||
| DLL_NAME="ccap.dll" | ||
| fi | ||
| if [ "${{ matrix.library_type }}" = "shared" ]; then | ||
| if [ -f "$DLL_NAME" ]; then | ||
| echo "✓ Windows shared library $DLL_NAME successfully built" | ||
| # Check if import library exists | ||
| if [ -f "${LIB_BASENAME}.lib" ]; then | ||
| echo "✓ Windows import library ${LIB_BASENAME}.lib also created" | ||
| fi | ||
| else | ||
| echo "✗ Windows shared library $DLL_NAME not found" | ||
| exit 1 | ||
| fi | ||
| else | ||
| if [ -f "${LIB_BASENAME}.lib" ]; then | ||
| echo "✓ Windows static library ${LIB_BASENAME}.lib successfully built" | ||
| else | ||
| echo "✗ Windows static library ${LIB_BASENAME}.lib not found" | ||
| exit 1 | ||
| fi | ||
| fi | ||
| - name: Test shared library linking (Windows) | ||
| if: matrix.library_type == 'shared' | ||
| shell: bash | ||
| working-directory: build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }} | ||
| run: | | ||
| echo "Testing Windows shared library linking..." | ||
| # Create a simple test program | ||
| cat > test_shared.cpp << 'EOF' | ||
| #include "ccap_c.h" | ||
| #include <stdio.h> | ||
| int main() { | ||
| const char* version = ccap_get_version(); | ||
| printf("Library version: %s\n", version ? version : "unknown"); | ||
| CcapProvider* provider = ccap_provider_create(); | ||
| if (provider) { | ||
| printf("Provider created successfully\n"); | ||
| ccap_provider_destroy(provider); | ||
| return 0; | ||
| } | ||
| return 1; | ||
| } | ||
| EOF | ||
| # Find Visual Studio compiler | ||
| VCVARS_PATH=$(find "/c/Program Files/Microsoft Visual Studio" -name "vcvars64.bat" 2>/dev/null | head -n1) | ||
| if [ -z "$VCVARS_PATH" ]; then | ||
| VCVARS_PATH=$(find "/c/Program Files (x86)/Microsoft Visual Studio" -name "vcvars64.bat" 2>/dev/null | head -n1) | ||
| fi | ||
| if [ -n "$VCVARS_PATH" ]; then | ||
| echo "Using Visual Studio environment from: $VCVARS_PATH" | ||
| # Convert path for cmd | ||
| VCVARS_WIN_PATH=$(echo "$VCVARS_PATH" | sed 's|/c/|C:/|g' | sed 's|/|\\|g') | ||
| # Determine library names based on config | ||
| if [ "${{ matrix.config }}" = "Debug" ]; then | ||
| LIB_NAME="ccapd.lib" | ||
| DLL_NAME="ccapd.dll" | ||
| else | ||
| LIB_NAME="ccap.lib" | ||
| DLL_NAME="ccap.dll" | ||
| fi | ||
| # Create a temporary batch file to avoid quote escaping issues | ||
| cat > compile_test.bat << EOF | ||
| @echo off | ||
| call "$VCVARS_WIN_PATH" | ||
| set "INCLUDE_DIR=%GITHUB_WORKSPACE%\\include" | ||
| if not exist "%INCLUDE_DIR%" ( | ||
| echo Include directory not found: %INCLUDE_DIR% | ||
| exit /b 1 | ||
| ) | ||
| cl /I"%INCLUDE_DIR%" test_shared.cpp $LIB_NAME /Fe:test_shared.exe | ||
| EOF | ||
| # Execute the batch file | ||
| cmd //c compile_test.bat | ||
| # Ensure DLL is available beside the test executable | ||
| if [ ! -f "./$DLL_NAME" ]; then | ||
| DLL_PATH=$(find .. -name "$DLL_NAME" -print -quit) | ||
| if [ -z "$DLL_PATH" ]; then | ||
| echo "✗ Windows shared library $DLL_NAME not found for runtime" | ||
| exit 1 | ||
| fi | ||
| cp "$DLL_PATH" . | ||
| fi | ||
| ./test_shared.exe | ||
| echo "✓ Windows shared library linking test passed" | ||
| else | ||
| echo "⚠ Visual Studio compiler not found, skipping link test" | ||
| fi | ||
| - name: Run Unit Tests | ||
| shell: bash | ||
| run: | | ||
| # Create symbolic links to make test script work with new build directory structure | ||
| mkdir -p build/tests | ||
| # Create symbolic link for the config directory | ||
| if [ ! -L "build/${{ matrix.config }}" ]; then | ||
| ln -sf "${{ matrix.config }}-${{ matrix.library_type }}" "build/${{ matrix.config }}" | ||
| fi | ||
| # Create symbolic link for the tests directory to match expected path structure | ||
| if [ ! -L "build/tests/${{ matrix.config }}" ]; then | ||
| ln -sf "../${{ matrix.config }}-${{ matrix.library_type }}/tests/${{ matrix.config }}" "build/tests/${{ matrix.config }}" | ||
| fi | ||
| cd scripts | ||
| if [ "${{ matrix.config }}" == "Debug" ]; then | ||
| # Set library path for shared library tests | ||
| if [ "${{ matrix.library_type }}" = "shared" ]; then | ||
| export PATH="$PWD/../build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}:$PATH" | ||
| fi | ||
| ./run_tests.sh --functional --skip-build | ||
| else | ||
| # Set library path for shared library tests | ||
| if [ "${{ matrix.library_type }}" = "shared" ]; then | ||
| export PATH="$PWD/../build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}:$PATH" | ||
| fi | ||
| ./run_tests.sh --performance --skip-build | ||
| fi | ||
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ccap-windows-${{ matrix.config }}-${{ matrix.library_type }} | ||
| name: ccap-windows-vs2022-${{ matrix.config }}-${{ matrix.library_type }} | ||
| path: | | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}/ccap*.* | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}/0-print_camera.exe | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}/1-minimal_example.exe | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}/2-capture_grab.exe | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }}/3-capture_callback.exe | ||
| build/${{ matrix.config }}-${{ matrix.library_type }}/*_results.xml | ||
| if-no-files-found: error | ||
| if-no-files-found: error | ||
|
|
||
| build-vs2026: | ||
| name: Windows Build VS2026 (${{ matrix.config }}-${{ matrix.library_type }}) | ||
| runs-on: windows-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| config: [Debug, Release] | ||
| library_type: [static, shared] | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Check for Visual Studio 2026 | ||
| id: check-vs2026 | ||
| shell: pwsh | ||
| run: | | ||
| Write-Host "Checking for Visual Studio 2026 on this runner..." | ||
| # Check if VS 2026 is available (stable or preview) | ||
| $vs2026Path = "C:\Program Files\Microsoft Visual Studio\2026" | ||
| $vs2026PreviewPath = "C:\Program Files\Microsoft Visual Studio\2026\Preview" | ||
| $vs2026EnterprisePath = "C:\Program Files\Microsoft Visual Studio\2026\Enterprise" | ||
| $vs2026ProfessionalPath = "C:\Program Files\Microsoft Visual Studio\2026\Professional" | ||
| $vs2026CommunityPath = "C:\Program Files\Microsoft Visual Studio\2026\Community" | ||
| $found = $false | ||
| if (Test-Path $vs2026PreviewPath) { | ||
| Write-Host "✓ Visual Studio 2026 Preview found at: $vs2026PreviewPath" | ||
| $found = $true | ||
| } elseif (Test-Path $vs2026EnterprisePath) { | ||
| Write-Host "✓ Visual Studio 2026 Enterprise found at: $vs2026EnterprisePath" | ||
| $found = $true | ||
| } elseif (Test-Path $vs2026ProfessionalPath) { | ||
| Write-Host "✓ Visual Studio 2026 Professional found at: $vs2026ProfessionalPath" | ||
| $found = $true | ||
| } elseif (Test-Path $vs2026CommunityPath) { | ||
| Write-Host "✓ Visual Studio 2026 Community found at: $vs2026CommunityPath" | ||
| $found = $true | ||
| } elseif (Test-Path $vs2026Path) { | ||
| Write-Host "✓ Visual Studio 2026 found at: $vs2026Path" | ||
| $found = $true | ||
| } | ||
| if ($found) { | ||
| echo "VS_2026_AVAILABLE=true" >> $env:GITHUB_ENV | ||
| } else { | ||
| Write-Host "ℹ Visual Studio 2026 is not available on this GitHub runner yet." | ||
| Write-Host "Available Visual Studio installations:" | ||
| Get-ChildItem "C:\Program Files\Microsoft Visual Studio" -Directory -ErrorAction SilentlyContinue | ForEach-Object { Write-Host " - $($_.FullName)" } | ||
| Write-Host "" | ||
| Write-Host "⏭ Skipping VS2026 build - this job will complete successfully without running the build." | ||
| Write-Host "Once GitHub adds VS2026 to their runners, this job will automatically start building." | ||
| echo "VS_2026_AVAILABLE=false" >> $env:GITHUB_ENV | ||
| } | ||
| - name: Setup latest CMake | ||
| if: env.VS_2026_AVAILABLE == 'true' | ||
| # Use @latest to ensure CMake 3.31+ is available, which is required for VS 2026 support | ||
| uses: lukka/get-cmake@latest | ||
|
|
||
| - name: Configure CMake with VS2026 | ||
| if: env.VS_2026_AVAILABLE == 'true' | ||
| run: | | ||
| $SHARED_FLAG = "" | ||
| if ("${{ matrix.library_type }}" -eq "shared") { | ||
| $SHARED_FLAG = "-DCCAP_BUILD_SHARED=ON" | ||
| Write-Host "Configuring Windows build ${{ matrix.config }} with VS2026 - SHARED LIBRARY (DLL)" | ||
| } else { | ||
| Write-Host "Configuring Windows build ${{ matrix.config }} with VS2026 - STATIC LIBRARY" | ||
| } | ||
| # Check CMake version | ||
| cmake --version | ||
| mkdir -p "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| cd "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| # Try Visual Studio 18 2026 generator | ||
| try { | ||
| Write-Host "Attempting to use Visual Studio 18 2026 generator..." | ||
| cmake ../.. -G "Visual Studio 18 2026" -A x64 -DCCAP_BUILD_TESTS=ON $SHARED_FLAG | ||
| } catch { | ||
| Write-Host "Visual Studio 18 2026 generator not available, trying alternative detection..." | ||
| cmake ../.. -A x64 -DCCAP_BUILD_TESTS=ON $SHARED_FLAG | ||
| } | ||
| - name: Build | ||
| if: env.VS_2026_AVAILABLE == 'true' | ||
| run: | | ||
| cd "build/${{ matrix.config }}-${{ matrix.library_type }}" | ||
| cmake --build . --config ${{ matrix.config }} --parallel | ||
| - name: Verify library type | ||
| if: env.VS_2026_AVAILABLE == 'true' | ||
| shell: bash | ||
| working-directory: build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }} | ||
| run: | | ||
| echo "Checking built libraries:" | ||
| ls -la | grep -E "ccap" || echo "No ccap libraries found" | ||
| # Verify library type | ||
| # Debug versions have 'd' suffix, Release versions don't | ||
| if [ "${{ matrix.config }}" = "Debug" ]; then | ||
| LIB_BASENAME="ccapd" | ||
| DLL_NAME="ccapd.dll" | ||
| else | ||
| LIB_BASENAME="ccap" | ||
| DLL_NAME="ccap.dll" | ||
| fi | ||
| if [ "${{ matrix.library_type }}" = "shared" ]; then | ||
| if [ -f "$DLL_NAME" ]; then | ||
| echo "✓ Windows shared library $DLL_NAME successfully built with VS2026" | ||
| # Check if import library exists | ||
| if [ -f "${LIB_BASENAME}.lib" ]; then | ||
| echo "✓ Windows import library ${LIB_BASENAME}.lib also created" | ||
| fi | ||
| else | ||
| echo "✗ Windows shared library $DLL_NAME not found" | ||
| exit 1 | ||
| fi | ||
| else | ||
| if [ -f "${LIB_BASENAME}.lib" ]; then | ||
| echo "✓ Windows static library ${LIB_BASENAME}.lib successfully built with VS2026" | ||
| else | ||
| echo "✗ Windows static library ${LIB_BASENAME}.lib not found" | ||
| exit 1 | ||
| fi | ||
| fi | ||
| - name: Test shared library linking (Windows VS2026) | ||
| if: env.VS_2026_AVAILABLE == 'true' && matrix.library_type == 'shared' | ||
| shell: bash | ||
| working-directory: build/${{ matrix.config }}-${{ matrix.library_type }}/${{ matrix.config }} | ||
| run: | | ||
| echo "Testing Windows shared library linking with VS2026..." | ||
| # Create a simple test program | ||
| cat > test_shared.cpp << 'EOF' | ||
| #include "ccap_c.h" | ||
| #include <stdio.h> | ||
| int main() { | ||
| const char* version = ccap_get_version(); | ||
| printf("Library version: %s\n", version ? version : "unknown"); | ||
| CcapProvider* provider = ccap_provider_create(); | ||
| if (provider) { | ||
| printf("Provider created successfully\n"); | ||
| ccap_provider_destroy(provider); | ||
| return 0; | ||
| } | ||
| return 1; | ||
| } | ||
| EOF | ||
| # Find Visual Studio 2026 compiler | ||
| VCVARS_PATH=$(find "/c/Program Files/Microsoft Visual Studio/2026" -name "vcvars64.bat" 2>/dev/null | head -n1) | ||
| if [ -n "$VCVARS_PATH" ]; then | ||
| echo "Using Visual Studio 2026 environment from: $VCVARS_PATH" | ||
| # Convert path for cmd | ||
| VCVARS_WIN_PATH=$(echo "$VCVARS_PATH" | sed 's|/c/|C:/|g' | sed 's|/|\\|g') |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
In general, fix this by explicitly declaring minimal GITHUB_TOKEN permissions in the workflow. You can set permissions at the top (workflow) level so it applies to all jobs, or individually per job. Since none of the jobs appear to need write access to repository contents, issues, or pull requests, contents: read is a safe baseline that still allows actions/checkout to function. Artifact upload and other steps here don’t require elevated repository permissions.
The single best fix with minimal functional impact is to add a root-level permissions block right after the name: line in .github/workflows/windows-build.yml, e.g. permissions: contents: read. This will apply to build-vs2022, build-vs2026, and build-mingw alike, and will satisfy CodeQL’s requirement for explicit permissions while ensuring that GITHUB_TOKEN cannot write to repository contents or other resources unnecessarily. No additional imports or definitions are needed, as this change is purely to the workflow metadata.
Specifically, edit .github/workflows/windows-build.yml near lines 1–3 to insert:
permissions:
contents: readbetween the existing name: and on: keys, keeping indentation consistent with the file.
| @@ -1,5 +1,8 @@ | ||
| name: Windows Build | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| # This workflow builds the project on Windows with multiple compilers: | ||
| # - build-vs2022: Uses Visual Studio 2022 (stable) | ||
| # - build-vs2026: Uses Visual Studio 2026 (when available on GitHub runners, skips gracefully if not) |
.github/workflows/windows-build.yml
Outdated
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix this, explicitly restrict the GITHUB_TOKEN permissions for the workflow (or at least for each job) to the minimal privileges required. All three jobs (build-vs2022, build-vs2026, build-mingw) only need to read the repository contents for actions/checkout and do not use GitHub write APIs, and actions/upload-artifact does not require repository permissions. Therefore, the best, non‑breaking fix is to add a top‑level permissions block with contents: read, which applies to all jobs.
Concretely, in .github/workflows/windows-build.yml, add:
permissions:
contents: readnear the top of the file, at the root level (same indentation as name: and on:), between the header comments and the on: block. No other code changes, imports, or definitions are needed, and functionality remains unchanged except that the GITHUB_TOKEN is now read‑only for repo contents, which is sufficient for this workflow.
| @@ -6,6 +6,9 @@ | ||
| # - build-mingw: Uses MinGW-w64 (latest version) | ||
| # All jobs test Debug/Release builds with static/shared library configurations. | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, ci_test ] |
.github/workflows/windows-build.yml
Outdated
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
In general, the fix is to declare an explicit permissions: block and set it to the minimal required scopes. Since this workflow only needs to read repository contents (for checkout) and upload artifacts (which does not require repo write access), the minimal safe permission is contents: read.
The best way to fix this without changing behavior is to add a top‑level permissions: block near the top of .github/workflows/windows-build.yml, immediately after the on: section (lines 9–15). This will apply to all jobs (build-vs2022, build-vs2026, and build-mingw) because none of them currently override permissions. No additional imports or library changes are needed; this is purely a YAML configuration change.
Concretely:
- Edit
.github/workflows/windows-build.yml. - After line 14 (
workflow_dispatch:) and the following blank line, insert:
permissions:
contents: readThis constrains GITHUB_TOKEN to read‑only repository contents for all jobs in this workflow.
| @@ -13,6 +13,9 @@ | ||
| branches: [ main, ci_test ] | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build-vs2022: | ||
| name: Windows Build VS2022 (${{ matrix.config }}-${{ matrix.library_type }}) |
|
@copilot 审查一下 msvc2026 的 workflow， 参考这个实现 https://github.com/x-ege/xege/blob/master/.github/workflows/msvc-build.yml 另外， mingw 的 workflow 有报错， 请修复，错误如下: |
已完成审查和修复： VS2026 workflow 改进：
MinGW workflow 修复：
错误已修复，MinGW 构建现在应该可以成功编译 GoogleTest 测试。 Commit: 974cb6c |
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
…dling Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
…available Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
…d issue - Use vswhere.exe to detect VS2026 (v144 toolset) properly - Switch from GITHUB_ENV to GITHUB_OUTPUT for step outputs - Fix PowerShell error handling using $LASTEXITCODE instead of try-catch - Fix bash string comparison (== to =) for POSIX compliance - Add -DGTEST_HAS_PTHREAD=0 for MinGW to fix AutoHandle compilation errors - Add proper test symlink structure for MinGW builds - Run tests for both Debug and Release in MinGW (not just Release) Co-authored-by: LeeGoDamn <243561453+LeeGoDamn@users.noreply.github.com>
Co-authored-by: LeeGoDamn <243561453+LeeGoDamn@users.noreply.github.com>
wysaid
force-pushed
the
copilot/add-msvc-2026-workflow
branch
from
bd57f32 to
83460ec
Compare
|
@copilot 编译 mingw 的 workflow 时， 还是有报错。 |
错误信息被截断了。能否提供完整的错误日志？从消息看到有一个 CMake 弃用警告（关于 GoogleTest 的 CMakeLists.txt），但我需要看到完整的错误才能诊断问题。 如果可以的话，请粘贴从 "CMake Deprecation Warning" 之后的完整错误信息，或者告诉我实际的构建失败在哪一步。 |
|
@copilot 下面是错误: 回顾一下上下文， 你也可以从已经运行的任务里面找到更全面的错误的信息 |
Add -Dgtest_disable_pthreads=ON to prevent GoogleTest from requiring Threads::Threads linkage on MinGW/Windows. This complements the existing -DGTEST_HAS_PTHREAD=0 flag by also disabling the CMake thread library search in GoogleTest's configuration. Co-authored-by: wysaid <1430725+wysaid@users.noreply.github.com>
... 已修复 Threads::Threads 链接错误。 问题原因：设置 解决方案：添加 现在 MinGW 构建应该可以成功编译了。 Commit: 5c6625b |
|
@copilot 这个问题在 workflow 里面别的任务里面依然存在。 请系统性过一下类似的问题， 全部都解决掉。 下面是问题: |
Add -DCMAKE_DISABLE_FIND_PACKAGE_Threads=TRUE to prevent CMake from finding the Threads package at all during GoogleTest configuration. This ensures the Threads::Threads target is never created, preventing linkage errors across all MinGW build configurations (Debug/Release, static/shared). Co-authored-by: LeeGoDamn <243561453+LeeGoDamn@users.noreply.github.com>
已系统性修复所有 MinGW 配置的 Threads::Threads 链接错误。 根本原因： 完整解决方案：
这将彻底解决所有 MinGW 构建配置（Debug/Release × static/shared）的问题。 Commit: e2ab737 |
|
@copilot mingw 的编译任务有报错， 解决一下， 下面是错误: |
Remove CMAKE_DISABLE_FIND_PACKAGE_Threads=TRUE which was preventing GLFW from finding required Threads package. Instead, use targeted approach: set CMAKE_THREAD_LIBS_INIT="" and THREADS_PREFER_PTHREAD_FLAG=OFF to prevent GoogleTest Threads linkage while allowing other components like GLFW to use Threads normally. Co-authored-by: LeeGoDamn <243561453+LeeGoDamn@users.noreply.github.com>
... 已修复。移除了 新方案使用更精准的配置：
这样可以让 GLFW 等组件正常使用 Threads 包，同时防止 GoogleTest 的 pthread 链接问题。 Commit: abfdb85 |
Add MSVC 2026 (Visual Studio 2026) and MinGW Workflow Support
This PR adds comprehensive Windows build support with multiple compilers.
Changes
Workflow (.github/workflows/windows-build.yml)
build-vs2022job - Uses Visual Studio 2022 (stable)build-vs2026job - Uses Visual Studio 2026 (when available on GitHub runners)vswhere.exeto check for VS2026 (v144 toolset)GITHUB_OUTPUTfor step outputsbuild-mingwjob - Uses MinGW-w64 with MSYS2 and Ninja build systemVS2026 Job Behavior
When VS2026 is available:
-T v144toolset flagWhen VS2026 is not available:
MinGW Build Features
msys2/setup-msys2@v2action for MinGW-w64 toolchainmingw-w64-x86_64-toolchain,cmake,ninjalibccap.a(static) orlibccap.dll(shared)-DGTEST_HAS_PTHREAD=0: Disables pthread code compilation in GoogleTest-Dgtest_disable_pthreads=ON: GoogleTest CMake option to disable pthread-DCMAKE_THREAD_LIBS_INIT="": Empty thread libs to prevent GoogleTest linkage errors-DTHREADS_PREFER_PTHREAD_FLAG=OFF: Disable pthread preferenceCode Quality Improvements
==→=) for POSIX compliance$LASTEXITCODEcheck)Documentation
Build Matrix
No breaking changes to existing VS 2022 builds.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.