Disable phpcs CI run while it is broken #3279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
force-pushed
the
phpcs4
branch
4 times, most recently
from
b32c8c1 to
2b60951
Compare
…he latest tag so that it doesn't break under us
meisterT
changed the title
Member
We needed this because the latest released version lacked something important IRC |
vmcj
added a commit
to vmcj/domjudge
that referenced
this pull request
Dec 8, 2025
Alternative for: DOMjudge#3279 IRC we needed the development branch for PHPCS support for PHP8.4, it might be they backported this already as PHP8.5 is now out so we need to check if they fixed this in a stable build.
vmcj
added a commit
to vmcj/domjudge
that referenced
this pull request
Dec 20, 2025
Alternative for: DOMjudge#3279 IRC we needed the development branch for PHPCS support for PHP8.4, it might be they backported this already as PHP8.5 is now out so we need to check if they fixed this in a stable build. Edit: Checked, the fixes are not backported, so we still need the development branch Disable unused version. Fix syntax job Revert "Fix syntax job" This reverts commit 823c571. Revert "Disable unused version." This reverts commit 30f7aa1. Revert "Trigger CI with no modifications" This reverts commit d56cee0. Try alternative solution Investigate the warning Re-order as we don´t get a simple composer.json yet Fixup Try with the new image Fixup use the correct path Trigger with the new PHP version Fix the image again Use right dir Use right syntax Update fix_pipelinecomponents_image.sh
vmcj
added a commit
to vmcj/domjudge
that referenced
this pull request
Dec 20, 2025
Alternative for: DOMjudge#3279 IRC we needed the development branch for PHPCS support for PHP8.4, it might be they backported this already as PHP8.5 is now out so we need to check if they fixed this in a stable build. Edit: Checked, the fixes are not backported, so we still need the development branch Disable unused version. Fix syntax job Revert "Fix syntax job" This reverts commit 823c571. Revert "Disable unused version." This reverts commit 30f7aa1. Revert "Trigger CI with no modifications" This reverts commit d56cee0. Try alternative solution Investigate the warning Re-order as we don´t get a simple composer.json yet Fixup Try with the new image Fixup use the correct path Trigger with the new PHP version Fix the image again Use right dir Use right syntax Update fix_pipelinecomponents_image.sh
vmcj
added a commit
to vmcj/domjudge
that referenced
this pull request
Dec 20, 2025
Alternative for: DOMjudge#3279 IRC we needed the development branch for PHPCS support for PHP8.4, it might be they backported this already as PHP8.5 is now out so we need to check if they fixed this in a stable build. Edit: Checked, the fixes are not backported, so we still need the development branch Disable unused version. Fix syntax job Revert "Fix syntax job" This reverts commit 823c571. Revert "Disable unused version." This reverts commit 30f7aa1. Revert "Trigger CI with no modifications" This reverts commit d56cee0. Try alternative solution Investigate the warning Re-order as we don´t get a simple composer.json yet Fixup Try with the new image Fixup use the correct path Trigger with the new PHP version Fix the image again Use right dir Use right syntax Update fix_pipelinecomponents_image.sh
Member
|
@meisterT I propose we close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably should not use the latest tag but some fixed version so that it doesn't break under us at random times