Replace PHPCompatibility image with our own to fix CI #3290
+2
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
trigger_ci_phpcs
branch
4 times, most recently
from
a651a05 to
defff4e
Compare
IRC we needed the development branch for PHPCS support for PHP8.4, PHP8.4 support is still not backported (even now PHP8.5 is out). We switch to another image as we now install the tool ourselves in our image. We used the default container as it would make maintenance easier but now we needed to patch the composer.json a couple of times so doing this ourselves from the start is easier.
vmcj
force-pushed
the
trigger_ci_phpcs
branch
from
0d5180f to
dcdae10
Compare
vmcj
changed the title
vmcj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for: #3279
IRC we needed the development branch for PHPCS support for PHP8.4, it might be they backported this already as PHP8.5 is now out so we need to check if they fixed this in a stable build.