Update Virginia 2025 Individual Income Tax Model #7057
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7057 +/- ##
============================================
- Coverage 100.00% 72.81% -27.19%
============================================
Files 11 3550 +3539
Lines 146 51113 +50967
Branches 0 263 +263
============================================
+ Hits 146 37219 +37073
- Misses 0 13874 +13874
- Partials 0 20 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add 2025 Form 760 references to 21 parameter files - Update rebate parameter with 2024 values ($200/$400) and 2025 values ($0) - Add 2025 tests for standard deduction ($8,750 single, $17,500 joint) - Add 2025 tests for EITC at 20% match rate - Add 2025 tests for military benefit subtraction ($40,000 limit) - Add 2025 tests for age deduction, exemptions, and rebate Fixes PolicyEngine#7056 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
DTrim99
force-pushed
the
update-va-2025-income-tax
branch
from
0befdbf to
27d1932
Compare
DTrim99
left a comment
DTrim99
left a comment
There was a problem hiding this comment.
PR Review Summary
This PR updates Virginia individual income tax parameters and tests for tax year 2025. The changes are well-organized and comprehensive.
Strengths
Parameter Updates (22 files):
- Added 2025 references to all parameter files pointing to 2025 Form 760 Instructions with specific page numbers
- Rebate values properly updated: 2024 ($200/$400) and 2025 ($0)
- References reordered chronologically (newest first) for better readability
- Fixed typo: "Appropirations" -> "Appropriations" in refundable.yaml
Test Coverage:
- Added 2025 EITC tests (both refundable and non-refundable at 20%)
- Added 2025 standard deduction tests for all filing statuses
- Added 2025 age deduction, personal exemption, aged/blind exemption tests
- Added 2025 military benefit subtraction tests
- Added 2025 rebate tests (correctly expecting $0)
- Tests properly use underscore thousands separators
Documentation:
- Changelog entry properly formatted with all major changes listed
- PR description includes clear status checklist and primary source reference
CI Status
Failing:
Check uv.lock freshness- The lock file needs to be updated. Runuv lockto regenerate it.
Pending:
- Full test suites are still running
Passing:
- Lint
- Quick Feedback tests
- Check version
Verification
EITC match rates verified against Virginia Tax guidance:
- Non-refundable EITC: 20% of federal EITC (unchanged)
- Refundable EITC: 20% of federal EITC (increased from 15% for 2025)
Minor Observations
-
Draft PR: The PR description indicates this is a draft for early visibility. The checklist shows several items still pending completion.
-
Future work mentioned: The PR description mentions potential future credits to implement (Credit for Taxes Paid to Another State, Food Donation Tax Credit, Firearm Safety Device Credit) - these are appropriately tracked as future considerations.
Required Action
To fix the CI failure, run:
uv lockThen commit and push the updated uv.lock file.
Summary
This is a well-structured parameter update with comprehensive test coverage for Virginia 2025 income tax. The EITC rates have been verified against official sources. Once the uv.lock file is updated and full test suites pass, this should be ready for merge.
1 participant
Summary
Update the Virginia individual income tax model for tax year 2025. This includes:
Fixes #7056
Status
Primary Source
2025 Virginia Form 760 Instructions
This is a draft PR created for early visibility. Implementation work is in progress.