Fix slash commands in subtask approval prompts #10552
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where slash commands typed at subtask approval prompts were incorrectly treated as denial feedback instead of being executed.
Changes
/) in theaskApprovalfunctionpresentAssistantMessage.tsProblem
When a user typed a slash command (e.g.,
/done) at theattempt_completionapproval prompt (the "finishTask" approval dialog) in a subtask, the slash command was processed as denial feedback instead of being executed. This meant users could not use slash commands while at the subtask completion approval prompt.Solution
The
askApprovalfunction now checks if the text starts with/before treating it as feedback. If it does, it treats it as a simple denial (similar to clicking the deny button without text), which allows the slash command to be processed correctly by the message handling system.Testing
View task on Roo Code Cloud
Important
Fixes slash command handling in subtask approval prompts by treating them as simple denials without feedback in
presentAssistantMessage.ts.presentAssistantMessage.ts,askApprovalfunction now checks if text starts with/and treats it as a simple denial without feedback.This description was created by
for 3b1c21c. You can customize this summary. It will automatically update as commits are pushed.