Skip to content

Fix slash commands in subtask approval prompts #10552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
Closed

Fix slash commands in subtask approval prompts #10552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 36 additions & 14 deletions src/core/assistant-message/presentAssistantMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,24 @@ export async function presentAssistantMessage(cline: Task) {

if (response !== "yesButtonClicked") {
if (text) {
await cline.say("user_feedback", text, images)
pushToolResult(
formatResponse.toolResult(
formatResponse.toolDeniedWithFeedback(text, toolProtocol),
images,
),
)
// Check if the text is a slash command (starts with /)
// Slash commands should not be treated as feedback to the model
const isSlashCommand = text.trimStart().startsWith("/")

if (isSlashCommand) {
// Treat slash commands as simple denial without feedback
// This prevents commands from being captured as denial feedback
pushToolResult(formatResponse.toolDenied(toolProtocol))
} else {
// Normal text feedback
await cline.say("user_feedback", text, images)
pushToolResult(
formatResponse.toolResult(
formatResponse.toolDeniedWithFeedback(text, toolProtocol),
images,
),
)
}
} else {
pushToolResult(formatResponse.toolDenied(toolProtocol))
}
Expand Down Expand Up @@ -589,13 +600,24 @@ export async function presentAssistantMessage(cline: Task) {
if (response !== "yesButtonClicked") {
// Handle both messageResponse and noButtonClicked with text.
if (text) {
await cline.say("user_feedback", text, images)
pushToolResult(
formatResponse.toolResult(
formatResponse.toolDeniedWithFeedback(text, toolProtocol),
images,
),
)
// Check if the text is a slash command (starts with /)
// Slash commands should not be treated as feedback to the model
const isSlashCommand = text.trimStart().startsWith("/")

if (isSlashCommand) {
// Treat slash commands as simple denial without feedback
// This prevents commands from being captured as denial feedback
pushToolResult(formatResponse.toolDenied(toolProtocol))
} else {
// Normal text feedback
await cline.say("user_feedback", text, images)
pushToolResult(
formatResponse.toolResult(
formatResponse.toolDeniedWithFeedback(text, toolProtocol),
images,
),
)
}
} else {
pushToolResult(formatResponse.toolDenied(toolProtocol))
}
Expand Down
Loading