-
Notifications
You must be signed in to change notification settings - Fork 16
Feature/fix intro story ui #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… height property size to Characters parts components
Codecov Report
@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
+ Coverage 83.05% 85.54% +2.48%
===========================================
Files 71 71
Lines 1216 1287 +71
Branches 60 68 +8
===========================================
+ Hits 1010 1101 +91
+ Misses 186 155 -31
- Partials 20 31 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tristanMatthias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcos5ilva , looking good. Just a couple of small formating issues, then should be good to go :)
| padding: ${t.size()} ${t.size('lg')}; | ||
| position: relative; | ||
| display: flex; | ||
| align - items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcos5ilva, this linting seems off?
| const Title = styled(Text)` | ||
| font-weight: ${t.fontWeight.bold}; | ||
| color: ${t.color('grey')}; | ||
| font - weight: ${t.fontWeight.bold}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here @marcos5ilva
Fixes
• #289
Changes
PR Checklist
yarn lintoryarn lint:fixyarn build