Skip to content

Conversation

@marcos5ilva
Copy link
Contributor

@marcos5ilva marcos5ilva commented Aug 15, 2020

Fixes

#289

Changes

  • Added cursor on hover action in the X close button
  • Fixed head and neck character in the right position

PR Checklist

  • Does your PR contain relevant tests that pass?
  • [ x] Is your code linted? yarn lint or yarn lint:fix
  • [x ] Does your code build correctly in ALL projects? yarn build

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #315 into develop will increase coverage by 2.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
+ Coverage    83.05%   85.54%   +2.48%     
===========================================
  Files           71       71              
  Lines         1216     1287      +71     
  Branches        60       68       +8     
===========================================
+ Hits          1010     1101      +91     
+ Misses         186      155      -31     
- Partials        20       31      +11     
Flag Coverage Δ
#unittests 85.54% <ø> (+2.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...api/src/UserPreferences/UserPreferences.service.ts 58.33% <0.00%> (-16.67%) ⬇️
packages/api/src/User/User.resolver.ts 85.29% <0.00%> (-11.49%) ⬇️
packages/api/src/User/User.service.ts 93.75% <0.00%> (-6.25%) ⬇️
packages/api/src/User/index.ts 100.00% <0.00%> (ø)
packages/api/src/Module/index.ts 100.00% <0.00%> (ø)
packages/api/src/User/User.entity.ts 100.00% <0.00%> (ø)
packages/api/src/UserModule/index.ts 100.00% <0.00%> (ø)
packages/api/src/UserModule/UserModule.resolver.ts 69.23% <0.00%> (ø)
packages/api/src/Module/Module.resolver.ts 90.47% <0.00%> (+4.76%) ⬆️
packages/api/src/Question/Question.entity.ts 92.68% <0.00%> (+8.06%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c86bd8...ff9fd10. Read the comment docs.

Copy link
Contributor

@tristanMatthias tristanMatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcos5ilva , looking good. Just a couple of small formating issues, then should be good to go :)

padding: ${t.size()} ${t.size('lg')};
position: relative;
display: flex;
align - items: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcos5ilva, this linting seems off?

const Title = styled(Text)`
font-weight: ${t.fontWeight.bold};
color: ${t.color('grey')};
font - weight: ${t.fontWeight.bold};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here @marcos5ilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants