-
Notifications
You must be signed in to change notification settings - Fork 16
Feature/fix intro story ui #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcos5ilva
wants to merge
5
commits into
develop
Choose a base branch
from
feature/fix-intro-story-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db69328
type(fix): fixed StyledCharacter's Body, Head, and Face CSS bottom at…
marcos5ilva 71642b0
type(fix): fixed StyledCharacter's styledCharacter bottom fro huge t…
marcos5ilva ef8dcd0
type(fix): Added link to Dashboard into Logo Icon
marcos5ilva 32e8b7d
type(fix): removed Dashboard link from the logo icon, added fixed CSS…
marcos5ilva ff9fd10
type(fix) refactored LessonHeader, and Sotry components due to lint i…
marcos5ilva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,38 +8,37 @@ import { Lesson, LessonState } from '../../containers/Lesson.container'; | |
| import { LessonProgress } from '../../components/LessonProgress/LessonProgress'; | ||
| import { routes } from '../../router/routes'; | ||
|
|
||
|
|
||
| // const offset: Size = 'lg'; | ||
| const CloseIcon = styled(Icon)` | ||
| cursor: pointer; | ||
| `; | ||
|
|
||
| const StyledLogo = styled(LogoMark)` | ||
| height: 100%; | ||
| `; | ||
|
|
||
| const Header = styled.header<{ withProgress: boolean }>` | ||
| position: relative; | ||
| display: flex; | ||
| align-items: center; | ||
| padding: ${t.size()} ${t.size('lg')}; | ||
| position: relative; | ||
| display: flex; | ||
| align - items: center; | ||
| padding: ${t.size()} ${t.size('lg')}; | ||
|
|
||
| & > div { | ||
| flex: 1; | ||
| text-align: center; | ||
| div { | ||
| margin: auto; | ||
| margin-top: ${t.size('sm')}; | ||
| max-width: 40rem; | ||
| } | ||
| flex: 1; | ||
| text - align: center; | ||
| div { | ||
| margin: auto; | ||
| margin - top: ${t.size('sm')}; | ||
| max - width: 40rem; | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| const Title = styled(Text)` | ||
| font-weight: ${t.fontWeight.bold}; | ||
| color: ${t.color('grey')}; | ||
| font - weight: ${t.fontWeight.bold}; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here @marcos5ilva |
||
| color: ${t.color('grey')}; | ||
| `; | ||
|
|
||
|
|
||
| const CloseConfirmModal: React.FC<{ onClose: () => void } & ModalProps> = ({ | ||
| onClose, | ||
| ...props | ||
|
|
@@ -54,47 +53,53 @@ const CloseConfirmModal: React.FC<{ onClose: () => void } & ModalProps> = ({ | |
| setRedirect(true); | ||
| }; | ||
|
|
||
| return <Modal | ||
| {...props} | ||
| onClose={onClose} | ||
| heading="Are you sure you want to quit?" | ||
| buttons={[ | ||
| <Button text color="primary" onClick={onClose}>Cancel</Button>, | ||
| <Button text color="tertiary" onClick={resetLesson}>Quit lesson</Button> | ||
| ]} | ||
| > | ||
| <Text>If you quit now, you will lose all your lesson progress!</Text> | ||
| </Modal>; | ||
| return ( | ||
| <Modal | ||
| {...props} | ||
| onClose={onClose} | ||
| heading="Are you sure you want to quit?" | ||
| buttons={[ | ||
| <Button text color="primary" onClick={onClose}> | ||
| Cancel | ||
| </Button>, | ||
| <Button text color="tertiary" onClick={resetLesson}> | ||
| Quit lesson | ||
| </Button> | ||
| ]} | ||
| > | ||
| <Text>If you quit now, you will lose all your lesson progress!</Text> | ||
| </Modal> | ||
| ); | ||
| }; | ||
|
|
||
| export const LessonHeader: React.FC<{ title?: string }> = ({ | ||
| title | ||
| }) => { | ||
| export const LessonHeader: React.FC<{ title?: string }> = ({ title }) => { | ||
| const [modal, setModal] = useState(false); | ||
| const { progress, lesson, lessonState } = Lesson.useContainer(); | ||
|
|
||
|
|
||
| return <Header withProgress={progress !== undefined}> | ||
| <StyledLogo /> | ||
|
|
||
| <div> | ||
| {title && <Title as="h2">{title}</Title>} | ||
| {lessonState === LessonState.lesson && <LessonProgress | ||
| current={progress!} | ||
| max={lesson!.lesson.questions.length} | ||
| />} | ||
| </div> | ||
|
|
||
| <CloseIcon | ||
| icon="x" | ||
| onClick={() => setModal(true)} | ||
| size="lg" | ||
| color="grey.300" | ||
| /> | ||
|
|
||
| <CloseConfirmModal | ||
| onClose={() => setModal(false)} | ||
| show={modal} | ||
| /> | ||
| </Header>; | ||
| return ( | ||
| <Header withProgress={progress !== undefined}> | ||
| <div> | ||
| <StyledLogo /> | ||
| </div> | ||
|
|
||
| <div> | ||
| {title && <Title as="h2">{title}</Title>} | ||
| {lessonState === LessonState.lesson && ( | ||
| <LessonProgress | ||
| current={progress!} | ||
| max={lesson!.lesson.questions.length} | ||
| /> | ||
| )} | ||
| </div> | ||
|
|
||
| <CloseIcon | ||
| icon="x" | ||
| onClick={() => setModal(true)} | ||
| size="lg" | ||
| color="grey.300" | ||
| /> | ||
|
|
||
| <CloseConfirmModal onClose={() => setModal(false)} show={modal} /> | ||
| </Header> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcos5ilva, this linting seems off?