forked from sd16spring/InteractiveProgramming
-
Notifications
You must be signed in to change notification settings - Fork 1
Added dynamic restart #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
therealcedz
wants to merge
36
commits into
guokevin:master
Choose a base branch
from
therealcedz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therealcedz - thanks for the note - appreciate the honesty. Nice job adding in dynamic restarting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did what I could for this revision. I originally wanted to change everything from client to server-side calculations, but the code was so messy and convoluted that it needed a whole entire structural update. The change would not have been easy (would have taken 1/2 as long as the project did, and this project was made with many MANY hours). I opted to create dynamic restarting. I noticed while people were play testing, they got tired of (or were annoyed) that they had to restart the game every time they wanted to play. With a bunch of modifying (the server to client data code is not pretty) I was able to do it with a few minor bugs (count down timer doesn't completely reset when you play again, and there's a small delay when you want to ready up in the lobby). Now the game can be played with endless (un-interrupted) fun!