Skip to content

Conversation

@shemogumbe
Copy link
Contributor

@shemogumbe shemogumbe commented Jan 8, 2025

Overview

Fixes #781

Demo

Running

python from msgraph_core import APIVersion, GraphClientFactory

Before the changes

Traceback (most recent call last): File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\app_test_lfu_changes.py", line 1, in <module> from msgraph_core import APIVersion, GraphClientFactory File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\__init__.py", line 16, in <module> from .tasks import PageIterator File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\__init__.py", line 2, in <module> from .large_file_upload import LargeFileUploadTask File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\large_file_upload.py", line 21, in <module> class LargeFileUploadTask: File "C:\Users\shemogumbe\kiota-python\msgraph-sdk-python-core\src\msgraph_core\tasks\large_file_upload.py", line 28, in LargeFileUploadTask parsable_factory: Optional[ParsableFactory[T]] = None, TypeError: 'ABCMeta' object is not subscriptable

After the changes - No error

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

@shemogumbe shemogumbe marked this pull request as ready for review January 8, 2025 14:54
@shemogumbe shemogumbe requested a review from a team as a code owner January 8, 2025 14:54
@shemogumbe shemogumbe merged commit f401001 into main Jan 9, 2025
14 checks passed
@shemogumbe shemogumbe deleted the shem/fix_parsable_factory_type_hint_error branch January 9, 2025 14:02
@baywet
Copy link
Member

baywet commented Jan 9, 2025

@shemogumbe please make sure you use conventional commit (fix: or feat: prefix) whenever merging/committing to trigger the releases and build the changelog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The msgraph-core 1.1.8 import of LargeFileUpload tasks raises 'ABCMeta' object is not subscriptable error

4 participants