Skip to content

remove generic from parsable factory type hint error #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shemogumbe merged 1 commit into from
Jan 9, 2025
Merged

remove generic from parsable factory type hint error #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/msgraph_core/tasks/large_file_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def __init__(
upload_session: Parsable,
request_adapter: RequestAdapter,
stream: BytesIO,
parsable_factory: Optional[ParsableFactory[T]] = None,
parsable_factory: Optional[ParsableFactory] = None,
max_chunk_size: int = 5 * 1024 * 1024
):
self._upload_session = upload_session
Expand Down Expand Up @@ -188,7 +188,7 @@ async def last_chunk(
file: BytesIO,
range_start: int = 0,
range_end: int = 0,
parsable_factory: Optional[ParsableFactory[T]] = None
parsable_factory: Optional[ParsableFactory] = None
) -> Optional[Union[T, bytes]]:
upload_url = self.get_validated_upload_url(self.upload_session)
if not upload_url:
Expand Down
Loading