Skip to content

Conversation

@MasterPtato
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
rivetkit-serverless Error Error Jan 6, 2026 1:34am
3 Skipped Deployments
Project Deployment Review Updated (UTC)
rivet-cloud Ignored Ignored Jan 6, 2026 1:34am
rivet-inspector Ignored Ignored Preview Jan 6, 2026 1:34am
rivet-site Ignored Ignored Preview Jan 6, 2026 1:34am

@vercel vercel bot temporarily deployed to Preview – rivetkit-serverless December 17, 2025 02:28 Inactive
Copy link
Contributor Author

MasterPtato commented Dec 17, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Dec 17, 2025

Pull Request Review: Dashboard Updates

Summary

This PR updates Grafana dashboard configurations across multiple docker development environments. The changes primarily involve formatting (array syntax) and replacing deprecated $__conditionalAll with standard ClickHouse array syntax.


Critical Issues

🔴 SQL Syntax Error in traces.json (ALL environments)

Location: rawSql query in traces.json files (line ~731 in template)

Issue: Malformed SQL query with syntax error:

TraceId IN array($trace_id),  $trace_id)

Problem: This has an extra , $trace_id) that creates invalid syntax. There is:

  1. An opening parenthesis without proper closure
  2. A duplicate/dangling $trace_id)

Expected (likely):

TraceId IN array($trace_id)

OR if conditional logic is needed:

$__conditionalAll(TraceId IN array($trace_id), $trace_id)

Impact: This query will fail at runtime when the "Error rates" panel tries to load data. The dashboard will show an error for this visualization.

Files affected (all 6 copies):

  • engine/docker/dev-host/grafana/dashboards/traces.json:728
  • engine/docker/dev-multidc-multinode/core/grafana/dashboards/traces.json:728
  • engine/docker/dev-multidc/core/grafana/dashboards/traces.json:728
  • engine/docker/dev-multinode/grafana/dashboards/traces.json:728
  • engine/docker/dev/grafana/dashboards/traces.json:728
  • engine/docker/template/grafana-dashboards/traces.json:731

Other Issues

⚠️ Missing Newline at EOF

Location: All JSON files

All modified files now end without a newline character. While JSON does not require trailing newlines, it is a common convention in this codebase and many POSIX tools expect it.

Recommendation: Add newline at end of files.


Positive Aspects

Consistent formatting: Array syntax is now consistently multi-line across all dashboards
Removed deprecated syntax: Replacing $__conditionalAll in api.json with proper array syntax is correct
Template propagation: Changes correctly propagated from template to all environment variants


Recommendations

  1. MUST FIX: Correct the SQL syntax error in traces.json rawSql query
  2. Should fix: Restore newlines at end of JSON files
  3. Testing: After fixing, verify dashboards load correctly in Grafana:
    • Check "Error rates" panel in traces dashboard
    • Verify "Method" filter works correctly in API dashboard
    • Test with different filter combinations

Process Note

Per CLAUDE.md, changes to docker/dev* configs should be made in docker/template/ and regenerated. This PR correctly follows that pattern, with changes in engine/docker/template/grafana-dashboards/ propagated to all variants.

However, the syntax error exists in the template itself, so fixing it there and regenerating will fix all copies.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3655

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3655

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3655

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3655

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3655

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3655

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3655

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3655

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3655

commit: 36bd554

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 6, 2026

Merge activity

  • Jan 6, 1:36 AM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jan 6, 1:37 AM UTC: CI is running for this pull request on a draft pull request (#3753) due to your merge queue CI optimization settings.
  • Jan 6, 1:37 AM UTC: Merged by the Graphite merge queue via draft PR: #3753.

graphite-app bot pushed a commit that referenced this pull request Jan 6, 2026
@graphite-app graphite-app bot closed this Jan 6, 2026
@graphite-app graphite-app bot deleted the 11-12-chore_update_dashboards branch January 6, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants