chore: fmt, fix config properties

[MasterPtato]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
rivetkit-serverless	Error		Jan 6, 2026 1:34am

3 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
rivet-cloud	Ignored		Jan 6, 2026 1:34am
rivet-inspector	Ignored	Preview	Jan 6, 2026 1:34am
rivet-site	Ignored	Preview	Jan 6, 2026 1:34am

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(ups): fix memory leak with local subscribers #3752
• chore: fmt, fix config properties #3749 👈 (View in Graphite)
• fix: fix gateway token reading, rivetkit path token, vergen git sha #3721
• chore: clean up metrics #3660
• fix: add wf and guard metrics #3657
• fix: revert otel metrics to prometheus #3656
• chore: update dashboards #3655
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: chore: fmt, fix config properties

This PR contains a collection of small maintenance improvements. Overall the changes look good, but I have some observations and questions below.

---

Positive Changes

1. Config validation improvements (runtime.rs, telemetry.rs):

   • Adding #[serde(deny_unknown_fields)] is excellent for catching configuration typos and preventing silent config errors
   • This will fail fast if users provide invalid config properties, which improves debuggability

2. Grafana dashboard fix (gasoline.json):

   • Fixes the Prometheus query to correctly convert millisecond timestamps to seconds by dividing by 1000
   • Removes unnecessary timestamp() wrapper which was incorrect usage
   • This should now accurately count workers that have pinged within the last 30 seconds

3. Signal buffer size reduction (pegboard/workflows/actor/mod.rs):

   • Reducing from 1024 to 256 signals in the buffer (3 locations) seems reasonable for memory optimization
   • Question: Was this change motivated by memory profiling or specific performance issues? It would be helpful to understand the reasoning, as this is a 75% reduction in buffer capacity

---

Minor Observations

1. Removed tracing span field (proxy_service.rs:2291):

   • Removed ?request_ids.ray_id from the ws_error_proxy_task span
   • Question: Was the ray_id field causing issues or was it redundant? Ray IDs are typically useful for tracing request flows, so understanding why it was removed would be helpful for future debugging

2. Deleted comment (pegboard/workflows/actor/mod.rs:824):

   • Removed a 3-line comment explaining why actors are allocated from within the actor workflow rather than via a signal to the runner workflow
   • Concern: This comment provided valuable context about a non-obvious architectural decision. Unless this information is documented elsewhere, removing it may make the codebase harder to understand for future maintainers
   • Suggestion: Consider restoring this comment or documenting this architectural decision in a more prominent location

---

Test Coverage

• For the Grafana dashboard query fix, it would be valuable to verify the query works correctly in a test environment
• The config validation changes should be covered by existing deserialization tests (if any exist)

---

Performance & Security

• No security concerns identified
• Signal buffer reduction should reduce memory usage slightly
• Config validation improves security posture by preventing silent misconfigurations

---

Summary

This is a solid maintenance PR. The main suggestions are:

1. Consider restoring the deleted architectural comment in pegboard/workflows/actor/mod.rs (or document it elsewhere)
2. Provide context for the signal buffer size reduction (256 vs 1024)
3. Clarify why ray_id was removed from the tracing span

Overall: Approved with minor suggestions

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-next-js
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-deno
• example-sqlite
• example-elysia
• example-experimental-durable-streams-ai-agent
• example-express
• example-hono
• hono-bun
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• example-node
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3749

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3749

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3749

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3749

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3749

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3749

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3749

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3749

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3749

commit: cb04567

[graphite-app]

Merge activity

• Jan 6, 1:36 AM UTC: MasterPtato added this pull request to the Graphite merge queue.
• Jan 6, 1:37 AM UTC: CI is running for this pull request on a draft pull request (#3753) due to your merge queue CI optimization settings.
• Jan 6, 1:37 AM UTC: Merged by the Graphite merge queue via draft PR: #3753.