nit: Add pagination bounds to prevent DoS via unbounded queries #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Queryvalidation tospans.py: limit (1-1000), page_number (>= 1)Queryvalidation toagent_api_keys.py: limit (1-1000), page_number (>= 1)Problem
Endpoints accepted unbounded
limitparameters, allowing requests like?limit=10000000that could exhaust server memory.Test Results
limit=10000limit=0page_number=0limit=100How to Verify
Files Changed
src/api/routes/spans.pysrc/api/routes/agent_api_keys.py