Skip to content

nit: Add pagination bounds to prevent DoS via unbounded queries #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smoreinis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nit: Add pagination bounds to prevent DoS via unbounded queries #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agentex/src/api/routes/agent_api_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import secrets

from fastapi import APIRouter, HTTPException
from fastapi import APIRouter, HTTPException, Query

from src.api.schemas.agent_api_keys import (
AgentAPIKey,
Expand Down Expand Up @@ -79,8 +79,8 @@ async def list_agent_api_keys(
agent_use_case: DAgentsUseCase,
agent_id: str | None = None,
agent_name: str | None = None,
limit: int = 50,
page_number: int = 1,
limit: int = Query(default=50, ge=1, le=1000),
page_number: int = Query(default=1, ge=1),
) -> list[AgentAPIKey]:
if not agent_id and not agent_name:
raise HTTPException(
Expand Down
6 changes: 3 additions & 3 deletions agentex/src/api/routes/spans.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from fastapi import APIRouter
from fastapi import APIRouter, Query

from src.api.schemas.spans import CreateSpanRequest, Span, UpdateSpanRequest
from src.domain.use_cases.spans_use_case import DSpanUseCase
Expand Down Expand Up @@ -80,8 +80,8 @@ async def get_span(
async def list_spans(
span_use_case: DSpanUseCase,
trace_id: str | None = None,
limit: int = 50,
page_number: int = 1,
limit: int = Query(default=50, ge=1, le=1000),
page_number: int = Query(default=1, ge=1),
order_by: str | None = None,
order_direction: str = "desc",
) -> list[Span]:
Expand Down
Loading