Test-case: Enhance "amixer" card selection #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch?
|
harajend
force-pushed
the
fix/verify-kernel-boot-log
branch
from
ae665c6 to
2722df4
Compare
This was referenced Jan 13, 2025
marc-hb
reviewed
Jan 13, 2025
Collaborator
There was a problem hiding this comment.
The commit message is empty.
Avoid vague words like "update" or "Enhance". Try to be as specific as possible, for instance "select the first card by name because it's not always numbered 0" (assuming I'm guessing correctly)
Note the review already started in #1245.
kv2019i
requested changes
Jan 15, 2025
Contributor
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code good, but git commit message needs to follow repository style (and have a signed off).
harajend
force-pushed
the
fix/verify-kernel-boot-log
branch
2 times, most recently
from
fba0b90 to
9969f61
Compare
kv2019i
approved these changes
Jan 15, 2025
marc-hb
reviewed
Jan 15, 2025
Select the first card by name because it is not always numbered 0 Signed-off-by: Hariprasad, Rajendra <hariprasad.rajendra@intel.com>
harajend
force-pushed
the
fix/verify-kernel-boot-log
branch
from
9969f61 to
a4dc166
Compare
marc-hb
approved these changes
Jan 16, 2025
Collaborator
|
Again, no Jenkins testing :-( |
ujfalusi
reviewed
Jan 17, 2025
| (set -x | ||
| # name= is hardcoded in /usr/share/alsa/ucm2/* | ||
| # - https://github.com/thesofproject/sof-test/issues/1244 | ||
| first_card_name=$(aplay -l | awk 'NR == 2 {print $3}') |
Contributor
There was a problem hiding this comment.
you could do the same with arecord and probably verify that the name starts with sof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Enhancement for "amixer" card selection: support card identification by name