Skip to content

Conversation

Copy link

Copilot AI commented Aug 6, 2025

This PR systematically removes function name prefixes from all logging calls throughout the src/ipc directory to improve log readability and reduce redundancy. Function names like "function_name():" at the beginning of log messages are now removed while preserving all other diagnostic information.

Changes Made

Updated logging calls across all files in src/ipc/ to remove function name prefixes from message strings:

Main IPC Files

  • src/ipc/dma-copy.c: Removed prefixes like "sg_get_elem_at():", "dma_copy_new():", "dma_copy_set_stream_tag():"
  • src/ipc/ipc-common.c: Removed "ipc_process_on_core():" prefix, improved "ipc_init()" to meaningful "Initializing IPC" message
  • src/ipc/ipc-helper.c: Removed prefixes like "comp_verify_params():", "ipc_pipeline_complete():", "ipc_comp_free():"

IPC3 Subdirectory

  • src/ipc/ipc3/helper.c: Removed prefixes including "comp_new():", "ipc_comp_new():", "get_drv():", "ipc_pipeline_new():", "ipc_buffer_new():", "ipc_comp_connect():"
  • src/ipc/ipc3/host-page-table.c: Removed "ipc_parse_page_descriptors():", "ipc_get_page_descriptors():" prefixes
  • src/ipc/ipc3/dai.c: Removed prefixes like "dai_config_dma_channel():", "dai_data_config():", "dai_config():", "ipc_comp_dai_config():"
  • src/ipc/ipc3/handler.c: Removed numerous probe function prefixes including "ipc_probe_init():", "ipc_probe_dma_add():", "ipc_probe_point_add():", etc.

IPC4 Subdirectory

  • src/ipc/ipc4/helper.c: Removed prefixes like "ipc_pipeline_free():", "comp_ipc4_get_attribute_remote():", "get_drv():", "ipc_comp_new():"
  • src/ipc/ipc4/dai.c: Removed prefixes including "dai_config_dma_channel():", "dai_data_config():", "dai_config():"

Examples

Before:

tr_err(&dmacpy_tr, "dma_copy_new(): dc->dmac = NULL");
comp_err(dev, "comp_verify_params(): !params");
tr_dbg(&ipc_tr, "ipc_probe_init()");

After:

tr_err(&dmacpy_tr, "dc->dmac = NULL");
comp_err(dev, "!params");
tr_dbg(&ipc_tr, "Initializing probe");

Summary

  • 84 lines changed across 9 files
  • No functional changes - only log message content modified
  • Preserved all diagnostic information including error codes, variable values, and formatting
  • Improved log readability by removing redundant function name prefixes
  • Maintained consistency with existing logging patterns

This change makes logs cleaner and more readable while ensuring all necessary diagnostic information is preserved for debugging purposes.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@sofci
Copy link
Collaborator

sofci commented Aug 6, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

@lyakh
Copy link
Collaborator

lyakh commented Aug 6, 2025

empty draft pushed by mistake

@lyakh lyakh closed this Aug 6, 2025
Copilot AI changed the title [WIP] Remove function names from all logging calls in src/ipc directory Remove function names from logging calls in src/ipc directory Aug 6, 2025
Copilot AI requested a review from lyakh August 6, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants