{Packaging} Drop msrestazure
#31066
Merged
{Packaging} Drop msrestazure
#31066
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
bebound,
wangzelin007 and
yonzhan
Member
Author
|
Besides managed identity authentication (#25959), azure-cli/src/azure-cli-core/azure/cli/core/util.py Lines 258 to 262 in 05a5d8f
https://github.com/search?q=repo%3AAzure%2Fazure-cli+empty_on_404&type=code and extensions: https://github.com/search?q=repo%3AAzure%2Fazure-cli-extensions%20empty_on_404&type=code |
Member
Commented in #29856 (comment) |
jiasli
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
jiasli
modified the milestones:
Build 2025 (2025-05-19)❗ Breaking change release ❗,
Backlog
Member
Author
Fixed by #31077 |
jiasli
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the msrestazure dependency from the project, streamlining the package requirements as it is no longer needed.
- Removed the msrestazure dependency line from the Windows requirements file
- Removed the msrestazure dependency line from the Linux requirements file
- Removed the msrestazure dependency line from the Darwin requirements file
- Removed the msrestazure dependency from the azure-cli-core setup script
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/requirements.py3.windows.txt | Removed msrestazure dependency |
| src/azure-cli/requirements.py3.Linux.txt | Removed msrestazure dependency |
| src/azure-cli/requirements.py3.Darwin.txt | Removed msrestazure dependency |
| src/azure-cli-core/setup.py | Removed msrestazure entry from dependency list |
Member
Author
|
Codegen Coverage task failed: LogsThis indicates these extensions still have dependency on
|
FumingZhang
previously approved these changes
Jun 6, 2025
This was referenced Jun 9, 2025
4 tasks
evelyn-ys
previously approved these changes
Jun 10, 2025
This was referenced Jun 10, 2025
Merged
evelyn-ys
approved these changes
Jun 10, 2025
bebound
approved these changes
Jun 11, 2025
This was referenced Jun 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
msrestazurerequiresadal. This PR dropsmsrestazureso that Azure CLI no longer depends onadal.